Bump rails main to dd1c884 + fix PWA route formats - #59
Merged
Conversation
- Includes GHSA-xr9x-r78c-5hrm fix: Active Storage disables libvips unfuzzed loaders (Vips.block_untrusted(true)) - solid_queue 1.5.0 -> 1.6.0 (fiber execution mode, additive) - annotaterb 4.23.0 -> 4.24.0 - 303 tests green, no deprecation warnings
rails main lost the PwaController formats fix, so /manifest 500s with
MissingTemplate for clients that send no Accept header. Pin the format
(defaults: { format: }) on both routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track rails/rails main at
dd1c884(2026-08-01), up fromcd269b7(2026-07-23).Included fixes
Vips.block_untrusted(true), disables libvips unfuzzed loaders) landed on main 07-27 and is now in. Drift has no attachments/variants, so the breaking side effect (BMP/ICO/PSD variants raisingVips::Error) does not apply.formats:fix, so/manifest500s with MissingTemplate for clients that send no Accept header. Pindefaults: { format: }on both routes (companion fix to tracking main — see invariant_pwa_routes_require_explicit_format_default).Bumped alongside (conservative mode couldn't hold these)
Verification
Vips.block_untrusted(true)confirmed present in installed activestoragee67032c) statically verified against the 07-31 Action Cable Server refactor: adapter'sdefined?(@server)fallback +respond_to?(:executor)branch both take the new API paths. No local runtime test exists (dev cable is async) — worth a /cable smoke test post-deploy.bin/rails routes -g manifestshows the pinned formats