Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: stats.variation: add/use temporary xp_copysign #4

Merged
merged 1 commit into from
May 6, 2024

Conversation

mdhaber
Copy link

@mdhaber mdhaber commented May 6, 2024

Reference issue

scipy#20647

What does this implement/fix?

Adds an xp_copysign to pass tests with array_api_strict.

Additional information

I don't expect it to be a big problem for this to ignore the special cases, but if you prefer, you can add them or just skip tests with array_api_strict until array_api_compat adds this.

I also took the opportunity to change the name of _move_axis_to_end to something that is more recognizable as a temporary array API function.

@j-bowhay
Copy link
Owner

j-bowhay commented May 6, 2024

Thanks!

@j-bowhay j-bowhay merged commit 5733dd8 into j-bowhay:xp_variation May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants