TST/STY: stats.combine_pvalues: refactor and test weight Stouffer statistic #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Jun 11, 2024
Comment on lines
+7975
to
+7978
| # Reference values computed using R `metap` `sumz`: | ||
| # options(digits=16) | ||
| # library(metap) | ||
| # x = c(0.01, 0.2, 0.3) |
There was a problem hiding this comment.
Feel free to replace these with what you had, "Same as no weights", if you prefer.
j-bowhay
approved these changes
Jun 11, 2024
j-bowhay
merged commit 16b6a2d
into
j-bowhay:combine_pvalues_test_refactor
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
scipygh-20934
What does this implement/fix?
Since I had to run the R code, I figured I would include it all together to make it easier for anyone to run. This allowed me to reduce the indent and whitespace. I went ahead and did the same for
test_weighted_stouffer, added the reference statistic values, and tighted the tolerance fromrtol=1-3to the default.