Refactor: SpotLightShadowRenderer reduce object allocations #2515
Conversation
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information |
codex128
added
the
Refactoring and Cleanup
| protected void getReceivers(GeometryList lightReceivers) { | ||
| lightReceivers.clear(); | ||
| Camera[] cameras = new Camera[1]; | ||
| cameras[0] = shadowCam; |
There was a problem hiding this comment.
I suggest keeping cameras[0] = shadowCam in, rather than only assigning during initialization. It makes this section much clearer.
| protected Vector3f[] points = new Vector3f[8]; | ||
| //Holding the info for fading shadows in the far distance | ||
|
|
||
| protected final Camera[] cameras = new Camera[1]; |
There was a problem hiding this comment.
Perhaps rename to tempCams since it is used as temporary storage of shadowCam.
This PR refactors the
SpotLightShadowRendererclass to improve code readability, consistency, and performance. Key changes include:Camera[] camerasin methods with a class-level field to avoid redundant allocations.These changes do not modify the core logic or functionality but streamline the implementation and improve maintainability.