Skip to content

fix: multiply staleness threshold by category-specific factors #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beardhatcode wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: multiply staleness threshold by category-specific factors #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c060cb7
fix: multiply staleness threshold by category-specific factors
beardhatcode Nov 28, 2025
961f3f3
clean: move staleness factor to init
beardhatcode Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion custom_components/marstek_local_api/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,15 @@ def __init__(
# Staleness tracking - track last successful update per category
self.category_last_updated: dict[str, float] = {}
self.STALENESS_THRESHOLD = 3 # missed updates before invalidation
self.STALENESS_FACTOR = {
"battery": UPDATE_INTERVAL_FAST,
"es": UPDATE_INTERVAL_FAST,
"em": UPDATE_INTERVAL_MEDIUM,
"pv": UPDATE_INTERVAL_MEDIUM,
"mode": UPDATE_INTERVAL_MEDIUM,
"ble": UPDATE_INTERVAL_SLOW,
"wifi": UPDATE_INTERVAL_SLOW,
}
self.STATIC_CATEGORIES = {"device", "wifi", "ble", "_diagnostic", "aggregates"}

# Initialize compatibility matrix for version-specific scaling
Expand Down Expand Up @@ -393,8 +402,10 @@ def is_category_fresh(self, category: str) -> bool:
last_update = self.category_last_updated[category]
elapsed = time.time() - last_update

category_stale_factor = self.STALENESS_FACTOR.get(category, 1)

# Calculate max age (update interval * threshold)
max_age = self.update_interval.total_seconds() * self.STALENESS_THRESHOLD
max_age = self.update_interval.total_seconds() * self.STALENESS_THRESHOLD * category_stale_factor

return elapsed < max_age

Expand Down