fix: correct battery temperature scaling for HW 2.0 FW ≥154 (use divi…#57
Open
CLeendert wants to merge 1 commit into
Open
fix: correct battery temperature scaling for HW 2.0 FW ≥154 (use divi…#57CLeendert wants to merge 1 commit into
CLeendert wants to merge 1 commit into
Conversation
|
hi there's also an issue with the remainin battery capacity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix battery temperature scaling for HW 2.0, FW ≥154.
Problem
Temps shown 10× too high due to divisor 0.1 (raw / 0.1 → ×10).
Change
Set SCALING_MATRIX['bat_temp'][(HW_VERSION_2, 154)] = 1 to use raw °C.
Notes
If devices return deci-°C integers (e.g., 253 → 25.3°C), divisor should be 10.0. Maintainer feedback welcomed on raw unit format.