Skip to content

Add CollectRowsInto to allow custom slice types #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ConsoleTVs wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add CollectRowsInto to allow custom slice types #2303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99b1fac
feat: better collect rows generic parameters
ConsoleTVs Apr 20, 2025
aa8483f
fix: revert original signature + add CollectRowsInto
ConsoleTVs Apr 20, 2025
ddf2250
fix: upload change
ConsoleTVs Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,15 @@ func CollectRows[T any](rows Rows, fn RowToFunc[T]) ([]T, error) {
return AppendRows([]T{}, rows, fn)
}

// CollectRowsInto is the same as [CollectRows] but allows
// defining a custom slice type. Useful when you have custom
// types to denote slices.
//
// This function closes the rows automatically on return.
func CollectRowsInto[S ~[]T, T any](rows Rows, fn RowToFunc[T]) (S, error) {
return CollectRows(rows, fn)
}

// CollectOneRow calls fn for the first row in rows and returns the result. If no rows are found returns an error where errors.Is(ErrNoRows) is true.
// CollectOneRow is to CollectRows as QueryRow is to Query.
//
Expand Down