-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(download): show saved file path in web read and weixin download output #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cbfbbe9
feat(download): show saved file path in web read and weixin download …
Benjamin-eecs b33c898
Merge remote-tracking branch 'upstream/main' into feat/show-saved-path
Benjamin-eecs 48b1f07
Merge remote-tracking branch 'upstream/main' into feat/show-saved-path
40d2820
Merge remote-tracking branch 'upstream/main' into feat/show-saved-path
c13b8dd
test(download): cover saved article path
jackwener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import * as fs from 'node:fs'; | ||
| import * as os from 'node:os'; | ||
| import * as path from 'node:path'; | ||
| import { afterEach, describe, expect, it } from 'vitest'; | ||
| import { downloadArticle } from './article-download.js'; | ||
|
|
||
| const tempDirs: string[] = []; | ||
|
|
||
| afterEach(() => { | ||
| for (const dir of tempDirs) { | ||
| try { | ||
| fs.rmSync(dir, { recursive: true, force: true }); | ||
| } catch { | ||
| // Ignore cleanup errors in tests. | ||
| } | ||
| } | ||
| tempDirs.length = 0; | ||
| }); | ||
|
|
||
| describe('downloadArticle', () => { | ||
| it('returns the saved markdown file path on success', async () => { | ||
| const tempDir = await fs.promises.mkdtemp(path.join(os.tmpdir(), 'opencli-article-')); | ||
| tempDirs.push(tempDir); | ||
|
|
||
| const result = await downloadArticle({ | ||
| title: 'Test Article', | ||
| author: 'Author', | ||
| publishTime: '2026-04-20 12:00:00', | ||
| sourceUrl: 'https://example.com/article', | ||
| contentHtml: '<p>Hello world</p>', | ||
| }, { | ||
| output: tempDir, | ||
| downloadImages: false, | ||
| }); | ||
|
|
||
| expect(result).toHaveLength(1); | ||
| expect(result[0].status).toBe('success'); | ||
| expect(result[0].saved).toMatch(new RegExp(`^${tempDir.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}`)); | ||
| expect(path.extname(result[0].saved)).toBe('.md'); | ||
| expect(fs.existsSync(result[0].saved)).toBe(true); | ||
| expect(fs.readFileSync(result[0].saved, 'utf8')).toContain('Hello world'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -56,6 +56,7 @@ export interface ArticleDownloadResult { | |||||
| publish_time: string; | ||||||
| status: string; | ||||||
| size: string; | ||||||
| saved: string; | ||||||
|
||||||
| saved: string; | |
| saved?: string; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
columnsadds the newsavedfield, but not all return paths in this command include it. In particular, the invalid-URL early return a few lines below returns an object withoutsaved, which makes output schema inconsistent. Update that return object to includesaved: '-'as well.