revert: undo #1081 output renderer patch#1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts
3bbea01(PR #1081) per @WAWQAQ direction in#opencli-pr-review:3ebc5a80.Why
The merged change optimized the table renderer around truncation/heuristics, but the clarified product direction is that this moved in the wrong direction: output design should be driven by result semantics / presentation policy first, not by making the table renderer smarter.
Reverted commit
3bbea01feat(output): optimize table formatting with width capping and key/value layout (#1081)Validation
node node_modules/vitest/vitest.mjs run src/output.test.tsnpm run typecheck