chore: remove JS-first migration residuals#931
Merged
Conversation
- Remove mapDistToSource() from diagnostic.ts — mapped dist/clis/ paths back to clis/ but dist/clis/ no longer exists after JS-first migration. The function always returned null. - Simplify resolveAdapterSourcePath() to check candidates directly without the dead dist→source mapping detour. - Delete scripts/clean-yaml.cjs — walked dist/clis/ to delete YAML files, but dist/clis/ no longer exists. - Remove clean-yaml script entry from package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up dead code left behind by the adapter JS-first migration (#928):
mapDistToSource()fromdiagnostic.ts— this function mappeddist/clis/paths back toclis/, butdist/clis/no longer exists. It always returnednullresolveAdapterSourcePath()— remove the dead dist→source mapping detour, check candidates directlyscripts/clean-yaml.cjs— walkeddist/clis/to delete YAML files, butdist/clis/no longer existsclean-yamlscript frompackage.jsonNote:
copy-yaml.cjsis kept — it still copiessrc/external-clis.yamltodist/src/which is used at runtime byexternal.ts.Test plan
src/diagnostic.test.ts— 30 tests passeddist/clisreferences in*.ts/*.js/*.cjs/*.json