Verify UTC zoneid as normalized object#250
Open
aguibert wants to merge 1 commit intojakartaee:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently it was pointed out by @martijndwars in this Yasson issue that we were not serializing
ZoneId.of("UTC")correctly:JSON-B spec section 3.5.3 states:
Martijn pointed out the following in his issue:
One of the Yasson contributors, @Degubi, fixed this issue in a Yasson PR.
When running the Yasson TCK with this change, I noticed that one test was expecting the incorrect behavior. It was expecting
ZoneId.of("UTC")to be serialized as the string"UTC", but it should be normalized to"Z"