Support for authentication using Service principal #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In config.ex we determine which type of autentication the user has choosen * The selected method is used via the Auth module which is to replace the SharedKey.sign function everywhere * Introduced an azure_integration test tag that will test against the real azure blob stoage
nomtrosk
force-pushed
the
support-service-principals
branch
from
889709a to
285b5a7
Compare
nomtrosk
changed the title
nomtrosk
changed the title
|
Awesome stuff, as a new user to this library. This PR came in just when I needed it. I found some issues when attempting to run this against CI and local testing that were easy to fix. I made those changes on a fork on my side and then extended this to allow for Managed Identities and User delegation SAS tokens. The changes I made to get this PR working against CI can be seen here: https://github.com/ktayah/azurex/commits/support-service-principals/ Let me know what you want to do, I can open a PR to merge those changes into this PR to start and then bring the other changes in separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design is as follow