Use branch's tracking remote in release script#334
Merged
TrevorBurnham merged 1 commit intojameskerr:mainfrom May 6, 2026
Merged
Conversation
Hardcoding `origin` breaks the release flow on a fork-with-upstream setup: `git fetch origin` and `git push origin` go to the fork, while the local branch tracks `upstream` and that's where the v* tag needs to land for the publish workflow to fire. Read the remote from `branch.<branch>.remote` so push/fetch follow the same target as `git push` without args.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/release.mjs(added in #333) hardcodedoriginfor the sync check and the final push. On a fork-with-upstream setup that's wrong: the localmaintracksupstream, and the v* tag has to land onupstreamfor.github/workflows/publish.ymlto fire. As-is,yarn releasewould push to the fork and silently no-op the publish.Change
Read the remote from
branch.<branch>.remote(the branch's actual upstream tracking remote) and use it for bothgit fetchandgit push. This matches the targetgit pushwould use with no args.Test plan
yarn release minor --preview --no-testson a clean main showsFetching upstreamand would push toupstreamrather thanorigin