fix(evals): un-break the R@5 failure-mode audit against the enveloped batch output#2247
Merged
Conversation
… batch output
The batch line moved its search payload under {"data": ...} (json_envelope);
the script read top-level results and scored 0/109 on every query with no
error surfaced. Unwrap the envelope (with pre-envelope fallback), type the
error check, and refresh docs/audit-r5-failure-modes.md + the raw record
with a current-config run (gemma-300m, PARSER_VERSION 17): crowding still
dominates near-misses on both splits (71.4% test / 57.1% dev).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The R@5 failure-mode audit script (
evals/audit_r5_failure_modes.py, April-era) had silently broken: batch output moved its search payload under the{"data": ...}envelope (json_envelope work) and the script read top-levelresults— every query scored 0/109 withresults: []and no error surfaced. A measurement tool reporting zeros instead of failing loudly is the docs-lying class applied to eval tooling.What lands
out.get("data", out)) + a typed error check (the current error line is{"error": {code, message}}).docs/audit-r5-failure-modes.md+evals/queries/v3_r5_audit.jsonrefreshed with a current-config run (gemma-300m, PARSER_VERSION 17, 18.3k chunks, v3 test split; dev also run, recorded in the research log).The refreshed finding (both splits, 14 near-misses each)
near_dup_crowdingstill dominates and grew: 71.4% test / 57.1% dev (April BGE-era: 60%). Paired-fixture agreement — real signal.#[cfg(test)]functions inside src files (e.g.src/parser/chunk.rstests) outranking gold production chunks (src/schema.sqltables) — test-code crowding is cfg-test-mod chunks insrc/, nottests/-dir files.docs/plan-file code blocks (eval_artifact_docs) — regeneration targets for the fixture program.🤖 Generated with Claude Code