test mapcat (#354)
#762
Open
test mapcat (#354)
#762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
requested changes
Sep 29, 2025
| (testing "function sometimes returns []" | ||
| (is (= [1 3 5] (mapcat #(if (odd? %) [%] []) (range 1 6))))) | ||
| (testing "function sometimes returns nil" | ||
| (is (= [2 4] (mapcat #(if (even? %) [%] nil) (range 1 5))))) |
There was a problem hiding this comment.
mapcat has a variadic arity, which we should test by passing many sequences. The most we're doing, in these tests, is two sequences.
|
Thanks for both of y'all's work! I'll take a look tonight |
E-A-Griffin
suggested changes
Sep 30, 2025
|
|
||
|
|
||
| (when-var-exists mapcat | ||
| (deftest common-cases |
There was a problem hiding this comment.
nitpick but why isn't the test name based on the var it's testing?
| (mapcat identity 5)))) | ||
| (testing "non-function first arg" | ||
| (is (thrown? #?(:cljs :default :clj Exception :cljr Exception) | ||
| (mapcat 42 [1 2])))))) |
There was a problem hiding this comment.
I'd add one more negative test for when the result of mapping isn't a concatable data structure, e.g.
(mapcat identity (range 2))
;; => Exception
|
@gavlooth if you're busy I don't mind making the changes, just would need write access to push to your fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.