Incremental work on task pages #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
janosh
commented
Feb 11, 2025
janosh
commented
- MetricScatter support date range and model filtering
- MetricsTable add callable prop model_filter
- drop non-compliant and energy-only toggles from discovery and phonons pages
- move Model name col from metrisc to metadata columns
- 2 new test cases for structure prototype labeling
- Update MetricScatter to support date range and model filtering - Modify MetricsTable to use flexible model filtering - Remove non-compliant and energy-only toggles from discovery and phonons pages - Add descriptive text and centered headings to metric visualization pages - Swap column order in metrics.ts to match updated design - Add new test structure files for prototype labeling
…g columns - Replace `hide_cols` and `show_metadata` props with flexible `col_filter` function - Split metrics into separate arrays: `DISCOVERY_METRICS`, `PHONON_METRICS`, and `ALL_METRICS` - Update MetricsTable and related pages to use new column filtering approach - Modify tests to reflect new column filtering mechanism - Ensure consistent column sorting with Model column first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.