Fix native Chip Select#11
Open
fridtjof wants to merge 1 commit into
Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_many sent the register and data in separate write calls, which triggered chip select twice, causing the first data byte to be interpreted as a register again.
I fixed this by sending each byte separately, which does introduce a slight overhead of (data_length - 1) bytes.
This could be reduced to 1 byte by transferring everything in one go, however this requires allocation to arrange the register byte and all data bytes for sending them in one go.
Of course, this being a no_std crate, introducing allocation seemed like a bit much for now.
This PR replaces #10 (I based it off a separate branch rather than master)