Treat integer Path.open argument as buffering - #157
Open
binggao1230 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128
Summary
Path.open()so an integer second positional argument is treated asbufferinginstead ofencodingopen("r", 1, encoding="utf-8")Tests
PYTHONPATH=. uv run --python 3.11 --with '.[test]' pytest tests/test_path.py::TestPath::test_open -qfailed with_extract_text_encoding() got multiple values for argument 'encoding'\n-PYTHONPATH=. uv run --python 3.11 --with '.[test]' pytest tests/test_path.py::TestPath::test_open -q\n-PYTHONPATH=. uv run --python 3.11 --with '.[test]' pytest tests/test_path.py::TestPath::test_open_encoding_utf16 tests/test_path.py::TestPath::test_open_encoding_errors tests/test_path.py::TestPath::test_open_binary_invalid_args tests/test_path.py::TestPath::test_read -q\n-PYTHONPATH=. uv run --python 3.11 --with '.[test]' pytest -q\n-PYTHONPATH=. uv run --python 3.11 --with '.[test,check]' pytest --ruff -q\n-PYTHONPATH=. uv run --python 3.11 --with mypy mypy zipp\n-git diff --check\n\nI also ranPYTHONPATH=. uv run --python 3.11 --with '.[test,type]' pytest --mypy -q; it currently reports existing test-suite typing issues whilepyproject.tomlhas the mypy pytest enabler disabled.\n\nAI assistance was used under my direction.