Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable preview mode #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable preview mode #58

wants to merge 2 commits into from

Conversation

dmfilipenko
Copy link

@dmfilipenko dmfilipenko commented Aug 14, 2021 •
edited
Loading

Previously it was enable, but I guess after rewriting it dissapear
#30

@dmfilipenko
Disable preview mode
52116c9 
Previously it was enable, but I guess after rewriting it dissapear
jaredpetersen#30 I
@dmfilipenko dmfilipenko changed the title [WIP] Disable preview mode Disable preview mode Aug 14, 2021
@dmfilipenko
Copy link
Author

@jaredpetersen wdyt about this pr?

jaredpetersen
jaredpetersen reviewed Aug 18, 2021
View reviewed changes
Copy link
Owner

@jaredpetersen jaredpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just disable preview mode without a CLI option on raspilive since it's not supposed to be there at all and there isn't any reason to keep it.

I'm always using a headless Pi so I just didn't notice it during the rewrite 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpetersen jaredpetersen jaredpetersen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmfilipenko @jaredpetersen