Handle some IllegalArgument cases in readBytes

[hiddenalpha]

The 2nd error covered here potentially could explain cases like #122 or related. Example: Passed-in 'byteCount' is either far too large or even a negative value which could trigger undesired behavior when used to allocate an array.

[hiddenalpha]

Where can I find an anyhow useful error message about why so many automated builds are failing? No matter where I click, It only literally says: "Error:". I have no idea what I should fix.

[tresf]

Where can I find an anyhow useful error message about why so many automated builds are failing? No matter where I click, It only literally says: "Error:". I have no idea what I should fix.

I think GitHub actions' log area uses JavaScript to expand the relevant section and navigate to the error. Depending on your browser, if this isn't firing it might be hiding everything.

Anyhow.... Here's what my browser shows:

Click to expand

cmake-build:
     [exec] [ 50%] Building CXX object CMakeFiles/jssc.dir/src/main/cpp/_nix_based/jssc.cpp.o
     [exec] /home/runner/work/jssc/jssc/src/main/cpp/_nix_based/jssc.cpp: In function ‘_jbyteArray* Java_jssc_SerialNativeInterface_readBytes(JNIEnv*, jobject, jlong, jint)’:
     [exec] /home/runner/work/jssc/jssc/src/main/cpp/_nix_based/jssc.cpp:674:33: error: expected unqualified-id before ‘&’ token
     [exec]   674 |     }catch( const std::bad_alloc& ex ){
     [exec]       |                                 ^
     [exec] /home/runner/work/jssc/jssc/src/main/cpp/_nix_based/jssc.cpp:674:33: error: expected ‘)’ before ‘&’ token
     [exec]   674 |     }catch( const std::bad_alloc& ex ){
     [exec]       |           ~                     ^
     [exec]       |                                 )
     [exec] /home/runner/work/jssc/jssc/src/main/cpp/_nix_based/jssc.cpp:674:33: error: expected ‘{’ before ‘&’ token
     [exec] /home/runner/work/jssc/jssc/src/main/cpp/_nix_based/jssc.cpp:674:35: error: ‘ex’ was not declared in this scope
     [exec]   674 |     }catch( const std::bad_alloc& ex ){
     [exec]       |                                   ^~
     [exec] gmake[2]: *** [CMakeFiles/jssc.dir/build.make:79: CMakeFiles/jssc.dir/src/main/cpp/_nix_based/jssc.cpp.o] Error 1
     [exec] gmake[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/jssc.dir/all] Error 2
     [exec] gmake: *** [Makefile:91: all] Error 2

[hiddenalpha]

I think GitHub actions' log area uses JavaScript to expand the relevant section and navigate to the error. Depending on your browser, if this isn't firing it might be hiding everything.

Thx. It really was that simple :) Didn't notice that actions require yet another domain to run JavaScript from.

[tresf]

No objections here... @pietrygamat did you have any unresolved comments to sort before merging?

[pietrygamat]

@tresf I'm good.