Unit test enhancement #523
Conversation
|
Hello @cyrille-artho, |
| NewThread t = new NewThread(); | ||
| t.start(); | ||
| MyHandler handler = new MyHandler(42); |
There was a problem hiding this comment.
If you move all code of the current thread up to before the new thread is created, there is nothing left to interleave for JPF. It may be the case that this test cannot be optimized without losing the fact that it verifies thread interleavings here.
|
Very few tests fail occasionally, but luckily, only rarely. I have restarted the CI build, and while waiting found that you probably removed the thread interleaving that the unit test in |
|
i see, this one is hard to optimized as it will risk compromising the thread interleaving verification. However, i think the most optimization we can do is to pre compute the expected class name it can reduce the time but i don't think it will be a significant imrpovement. it can be something like ~3-4 seconds. i will try to do my best here to see if further significant improvements can be done Thanks a lot for your help! |
|
Sometimes the required complexity of a test is intrinsic (it's in the nature of the problem) and cannot be reduced further. In that case, that's fine, and at least we have reviewed the test now and know the complexity is not accidental (being caused by a poor approach to the problem). |
Hi, I find this case fails in my machine also 🤣 |
|
Does that test fail consistently on your machine, or occasionally? In the CI setup on GitHub, it fails only very rarely so we can keep the test. If it fails consistently on some systems, it is worth investigating this. If we can't fix the problem, we might remove the test instead. |
|
It works on my machine no problem with it. |
|
I'm using ubuntu 24 under |
now testProxyCreationInCaseOfChoiceGenerator() is faster:
in the original approach we were creating the thread then the proxy in the main thread. but now we are creating the proxy in the main thread then the thread itself. so this can reduce conncurrent operation and minimize the satate space.
and when it comes to verification order the original approach verifying the the cross thread equality then the class format now i switched it as it can front-loads complex verification in single-threaded contex.
the old test were taking up to 14 seconds now its about ~1 second