fix(health): ensure playback failures trigger immediate repair #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify RegisterCorruptedFile to set status to pending with high priority and maxed retries. - Update UpdateFileHealth to use max_retries - 1 and high priority when noRetry is true (playback errors). - Update metadata filesystem to report playback errors as pending in DB to trigger repair cycle. - Add regression test for playback failure behavior in health_repository_test.go. - Fix scan error in tests by updating priority column type to INTEGER in test setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file fails during playback due to missing Usenet articles, it currently enters a 'corrupted' dead-end state because the health worker excludes corrupted files from checks.
This PR modifies the behavior to: