refactor(health): remove dead code and fix Go anti-patterns #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused HealthConfig struct and EventHandler type from checker.go - Remove PendingManualChecks field from WorkerStats (no longer used) - Rename config.go to controller.go to match its contents - Fix context anti-pattern: pass ctx as parameter instead of storing in struct - Extract processMetadataForSync helper to reduce code duplication - Extract updateSymlinkForMountChange helper for symlink updates - Fix UsedFiles comment to match struct name - Inline thin config getter wrapper functions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
drondeseries
added a commit
to drondeseries/altmount
that referenced
this pull request
Dec 29, 2025
refactor(health): remove dead code and fix Go anti-patterns (javi11#179)
drondeseries
added a commit
to drondeseries/altmount
that referenced
this pull request
Dec 29, 2025
refactor(health): remove dead code and fix Go anti-patterns (javi11#179)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HealthConfigstruct andEventHandlertype from checker.goPendingManualChecksfield fromWorkerStats(no longer used after manual queue removal)config.gotocontroller.goto accurately reflect its contents (HealthSystemController)processMetadataForSynchelper to reduce code duplication inSyncLibraryandsyncMetadataOnlyupdateSymlinkForMountChangehelper for symlink updates ingetAllLibraryFilesandgetAllImportDirFilesUsedFilescomment to match struct nameTest plan
go build ./...passesgo test ./internal/health/...passes🤖 Generated with Claude Code