refactor(importer): remove dead code and consolidate archive processing #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused functions and consolidate duplicate archive processing logic: - Remove unused FormatInt() from archive/common.go - Remove 6 unused functions from utils/file_extensions.go: AllExtensions, AllExtensionsWith, AllPossibleExtensions, WhatIsMostLikelyExtension, sniffTextOrNZB, isLikelyUTF8 - Remove unused imports (bufio, os, mimetype) - Extract common archive processing logic into processArchive() - Fix severe formatting corruption in processSevenZipArchive() - Reduce code duplication between RAR and 7zip processing (~80 lines) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FormatInt()function fromarchive/common.goutils/file_extensions.go(AllExtensions,AllExtensionsWith,AllPossibleExtensions,WhatIsMostLikelyExtension,sniffTextOrNZB,isLikelyUTF8)bufio,os,github.com/gabriel-vasile/mimetype)processArchive()functionprocessSevenZipArchive()(mixed tabs/spaces)Test plan
go build ./...passesgo vet ./internal/importer/...passesgo test ./internal/importer/...passes🤖 Generated with Claude Code