[Mosaic] NFC: Refactor Mosaic canonicalization pass to use RewritePattern. #28250
+277
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_751146100
branch
2 times, most recently
from
4c08ef8 to
dce0393
Compare
…tern. Right now, we're manually canonicalizing ops generated in the pattern (See arith::FPToSIOp and vector::ContractionOp). Also we might have an op that has both standalone and elementwise canonicalization pattern (e.g., arith::Select is suitable for elementwise upcast), and the current approach is bug-prone because each rule invalidates op. RewritePattern infra seems a good-fit here. One caveat is that we're also doing (pre-infer) verification in the canonicalization pass while RewritePattern uses mlir::failure() to identify whether the transformation converges. I make it a tri-state instead: - If op is rewritten, return `success()`. - If op is not matched and just passes through, return silent `failure()` without any diagnostic messages. - If op is invalid, return `failure()` with a meaningful diagnostic message. But, we should consider separating verification from canonicalization too. PiperOrigin-RevId: 751146100
copybara-service
bot
force-pushed
the
test_751146100
branch
from
dce0393 to
bb1ef9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic] NFC: Refactor Mosaic canonicalization pass to use RewritePattern.
Right now, we're manually canonicalizing ops generated in the pattern (See arith::FPToSIOp and vector::ContractionOp). Also we might have an op that has both standalone and elementwise canonicalization pattern (e.g., arith::Select is suitable for elementwise upcast), and the current approach is bug-prone because each rule invalidates op.
RewritePattern infra seems a good-fit here. One caveat is that we're also doing (pre-infer) verification in the canonicalization pass while RewritePattern uses mlir::failure() to identify whether the transformation converges. I make it a tri-state instead:
success().failure()without any diagnostic messages.
failure()with a meaningful diagnostic message.But, we should consider separating verification from canonicalization too.