Avoid strong refs to tracers in DynamicJaxprTrace. #29937
Merged
+109
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougalm
force-pushed
the
avoid-strong-refs
branch
8 times, most recently
from
1b1f952 to
e8c56d7
Compare
We're doing this in anticipation of implementing on-the-fly trace-time DCE by allowing dead eqns to be dropped. Strong refs to tracers get in the way of that.
dougalm
force-pushed
the
avoid-strong-refs
branch
from
e8c56d7 to
4d718ca
Compare
mattjj
approved these changes
Jul 2, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
PiperOrigin-RevId: 778903328
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
PiperOrigin-RevId: 778903328
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
PiperOrigin-RevId: 778921020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're doing this in anticipation of implementing on-the-fly trace-time DCE by allowing dead eqns to be dropped. Strong refs to tracers get in the way of that.