Chat Phase 2b-1 — threads, attachments, shared file picker, chat guide #236
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // desktop/src/apps/chat/AttachmentGallery.tsx | ||
| import { useState } from "react"; | ||
| import type { AttachmentRecord } from "@/lib/chat-attachments-api"; | ||
| import { AttachmentLightbox } from "./AttachmentLightbox"; | ||
|
|
||
| export function AttachmentGallery({ attachments }: { attachments: AttachmentRecord[] }) { | ||
| const [lightboxStart, setLightboxStart] = useState<number | null>(null); | ||
| if (!attachments?.length) return null; | ||
| const images = attachments.filter((a) => a.mime_type?.startsWith("image/")); | ||
| const files = attachments.filter((a) => !a.mime_type?.startsWith("image/")); | ||
|
|
||
| const gridClass = images.length > 1 ? "grid grid-cols-2 gap-1 max-w-md" : ""; | ||
|
|
||
| return ( | ||
| <div className="flex flex-col gap-2 mt-1"> | ||
| {images.length > 0 && ( | ||
| <div className={gridClass}> | ||
| {images.slice(0, 4).map((img, i) => ( | ||
| <button key={img.url} onClick={() => setLightboxStart(i)} className="relative block"> | ||
| <img | ||
| src={img.url} | ||
| alt={img.filename} | ||
| className={images.length === 1 | ||
| ? "max-w-[560px] max-h-[400px] rounded" | ||
| : "object-cover w-full h-32 rounded"} | ||
| /> | ||
| {images.length > 4 && i === 3 && ( | ||
| <span className="absolute inset-0 bg-black/60 flex items-center justify-center text-white"> | ||
| +{images.length - 4} more | ||
| </span> | ||
| )} | ||
| </button> | ||
| ))} | ||
| </div> | ||
| )} | ||
| {files.length > 0 && ( | ||
| <div className="flex flex-col gap-1"> | ||
| {files.map((f) => ( | ||
| <a key={f.url} href={f.url} target="_blank" rel="noreferrer" | ||
| className="flex items-center gap-2 bg-white/5 hover:bg-white/10 rounded px-2 py-1 text-sm max-w-sm"> | ||
| <span aria-hidden>📄</span> | ||
| <span className="truncate">{f.filename}</span> | ||
| <span className="ml-auto text-xs opacity-60"> | ||
| {Math.max(1, Math.round(f.size / 1024))} KB | ||
| </span> | ||
| </a> | ||
| ))} | ||
| </div> | ||
| )} | ||
| {lightboxStart !== null && ( | ||
| <AttachmentLightbox | ||
| images={images} | ||
| startIndex={lightboxStart} | ||
| onClose={() => setLightboxStart(null)} | ||
| /> | ||
| )} | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't gate the HTTP send paths on WebSocket state.
This early return blocks attachment sends and other REST-backed flows whenever the socket drops, even though they do not need WS. Only the final text-only WS fallback should require
readyState === 1.Suggested fix
const sendMessage = async () => { const text = input.trim(); if (!text && pendingAttachments.length === 0) return; - if (!selectedChannel || !wsRef.current || wsRef.current.readyState !== 1) return; + if (!selectedChannel) return; // Block send while uploads are in-flight if (pendingAttachments.some((a) => a.uploading)) { setSendError("waiting for uploads to finish…"); return; @@ - if (!text) return; + if (!text) return; + if (!wsRef.current || wsRef.current.readyState !== 1) return;🤖 Prompt for AI Agents