Correct the competitor comparison and drop em-dashes - #3
Conversation
The "Why this and not the others?" table asserted that Home Mind depends
on ChromaDB / FAISS / LangChain. It does not. I cloned hoornet/home-mind
and grepped it: zero references to chromadb, chroma, faiss, or langchain
anywhere in the tree, and 23 files referencing Shodh, which is a separate
cognitive-memory engine.
The claim is accurate for hass-agent-llm, which does use ChromaDB, but it
was stated as universal. Home Mind is a 67-star project with an active
maintainer who can refute this in one comment, so it is the single riskiest
line in the repo ahead of an announcement.
Reworded to "retrieval-based" and "Varies (Shodh, ChromaDB, …)", which is
defensible against both projects. The rest of the table stands: the
footprint and top-k retrieval rows are fair, and the scaling row is
honestly self-deprecating. info.md carried the same claim in a stronger
form ("Existing solutions all use vector DBs"); fixed there too.
Also:
- Dropped "works identically with all of them" for the four providers.
The suite is unit-only, so nothing in-repo backs "identically."
- Removed a dead `if TYPE_CHECKING: pass` block and its now-unused import.
- Removed em-dashes across prose. One of them was runtime output:
_index_line generated an em-dash into every user's MEMORY.md. Safe to
change, since dedup matches on the "- [name](" prefix and never on the
separator, so existing indexes keep working.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
✅ Action performedFull review finished. Your plan includes PR reviews subject to rate limits. More reviews will be available in 53 minutes. |
The comparison row 'Index always in prompt' described the other side as 'top-k retrieval'. Home Mind is not top-k: its shodh-client documents a hybrid strategy that always pulls the user's tagged fact set, and its CHANGELOG records fixing pure activation-based retrieval because it was dropping facts. That is the same failure mode this PR was opened to fix, one row below the row it fixed. 'Retrieved per turn' holds for both hybrid and top-k designs, so the column still says what it needs to say without naming a mechanism a maintainer can refute. Also repairs three comma splices left by the em-dash sweep.
1 participant
Pre-announce verification pass.
The one that matters: a factually wrong claim about a named competitor
The "Why this and not the others?" table asserted:
with the header naming Home Mind and hass-agent-llm, plus prose saying "Other HA memory integrations use vector embeddings, ChromaDB, or LangChain."
That is wrong about Home Mind. I cloned
hoornet/home-mindand grepped the tree:It uses Shodh Memory, a separate cognitive-memory engine. The claim is correct for
hass-agent-llm, but it was stated as universal.Home Mind has 67 stars and a maintainer who pushed 16 days ago. On Show HN or r/homeassistant this is one comment away from being refuted, and a refuted competitor claim reframes an entire thread around your credibility rather than your project.
Reworded to "retrieval-based" and
Varies (Shodh, ChromaDB, …), which is defensible against both.info.mdcarried the same claim in a stronger form ("Existing solutions all use vector DBs") and is fixed too.The rest of the table I checked and left alone: top-k retrieval, non-trivial footprint, and the self-deprecating "scales to 10,000s ❌" row are all fair.
Also
if TYPE_CHECKING: passblock and its now-unused import._index_linegenerated an em-dash into every user'sMEMORY.md. Verified safe to change: dedup matches on the- [name](prefix and never on the separator, so existing user indexes keep working.Verification, and its limit
Files compile and the removed import has no remaining references, checked statically.
I could not run the pytest suite locally. The box is at 100% disk and
pytest-homeassistant-custom-componentpulls the fullhomeassistantwheel, which fails with ENOSPC. I did not clear caches to make room. CI runs the suite on this branch, so please confirm green there before merging rather than taking my word for it.Clean
Secrets, network data, and employer references all came back clean across the working tree and all 14 commits.