Skip to content

Conversation

@phoebebright
Copy link

No description provided.

Copy link
Contributor

@newearthmartin newearthmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add the app name newsletter, then the path names should not be prefixed with newsletter.

So newsletter_subscribe_request should become newsletter:subscribe_request

This would break backwards compatibility BTW but I think its a necessary change if we are going to add app_name.

@newearthmartin
Copy link
Contributor

newearthmartin commented Aug 29, 2025

Actually, this is already a breaking change because, for example, the Newsletter method already does not work:

    def update_url(self):
        return reverse('newsletter_update_request', kwargs={'newsletter_slug': self.slug})

It should be changed to newsletter:newsletter_update_request. Then it would be better that it becomes just newsletter:update_request

Can you please update all path names to remove the prefix, and also update all references to these paths?

@newearthmartin newearthmartin force-pushed the master branch 7 times, most recently from 716b4d8 to e48481c Compare September 7, 2025 06:04
@newearthmartin newearthmartin linked an issue Sep 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding app_name in urls.py

2 participants