build: Build with Java 25 toolchain - #2448
Merged
Merged
Conversation
maxandersen
marked this pull request as ready for review
May 8, 2026 13:37
Collaborator
Author
|
@quintesse please take a look to see if i've missed something here and if you see any problems with this one. |
quintesse
approved these changes
May 8, 2026
quintesse
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I'd even say that we could make the version used for tests much newer. I mean if we build with 25 anyway, why not test with 25 as well? Is there a reason we shouldn't do that?
Collaborator
Author
|
We can definitely add 25 in matrix if missing. We test on 11 at runtime to ensure it doesn't accidentally rely on multijars different behaviours. For integration tests we can run test with 25 and just run with different external vm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is with intent of having faster builds an potentially use markdown in javadoc; but also to allow use of newer gradle plugins to handle git versioning that does not break with git worktrees.
Summary
Update the build toolchain from Java 11 to Java 25 while keeping the same bytecode targets (
--release 8for main code,--release 9for multi-release,--release 11for tests).Changes
build.gradle— ToolchainlanguageVersion11 → 25.github/actions/shared-build-setup/action.yml— Defaultjava-version11 → 25 (avoids Gradle auto-provisioning overhead).github/workflows/step-ci-build.yml— Unit test job now usesmatrix.java-version(currently[11]) with-PtestJavaVersion, matching the integration test patternNotes
--release 8still works on JDK 25 but emits a deprecation warning ("source value 8 is obsolete and will be removed in a future release")