fix: resolve jbang deps search hang on Windows #2549

[arnabnandy7]

Title

fix: resolve jbang deps search hang on Windows

Fixes #2549

Description

This PR resolves the issue where jbang deps search hangs indefinitely and produces no output when run on Windows.

Cause

The terminal backend in JBang for the deps search TUI widget is implemented using TamboUI's tamboui-aesh-backend.

By default, the backend's constructor instantiates a new org.aesh.terminal.tty.TerminalConnection to connect to the system terminal. However, because JBang is already running within an active Aesh shell session, trying to open a second native system terminal connection to the same console session on Windows results in a conflict/deadlock, causing the process to hang without displaying the UI.

Solution

• Modified Deps.java to extract the active org.aesh.terminal.Connection instance from Aesh's command invocation context using commandInvocation.getShell().connection().
• Updated ArtifactSearchWidget.java to support an overloaded search(Connection connection, String initialQuery) method.
• Reconfigured the TUI initialization to reuse the connection if it's available:

  AeshBackend backend = new AeshBackend(connection);
  TuiConfig config = TuiConfig.defaults().toBuilder().backend(backend).build();

• If no connection is passed (e.g. falls back to default), it defaults back to creating a new terminal connection.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0eb75889-fd25-4261-a0c3-f1b29ae6556b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[maxandersen]

these changes in NetUtil seems unrelated?

[maxandersen]

please don't use fully qualified classnames unless actually required.

[maxandersen]

pushed fixes for the review - will merge when test passes

[arnabnandy7]

pushed fixes for the review - will merge when test passes

@maxandersen thanks for the review and remedial.