fix: allow {basename} sidecar files with different extensions - #2648
Merged
Conversation
- {filename} and {basename} have different validation rules for their usage
- Test for case when {basename} is being used in a template file ref
- fixes jbangdev#1318
- Test for Init.resolveBaseName
Tests that the name given by the user matches the template
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives and rebases #1319 from @nandorholozsnyak onto current
main.Fixes #1318.
Templates may use
{filename}for their primary output and{basename}for sidecar files with different extensions, for example:Extension validation now applies to the primary template output rather than every
{basename}sidecar. Templates containing only{basename}entries still validate against the first entry, preserving the behavior requested in the original review.Also updates the original tests to use the current
JBang.execute()API.Verification
./gradlew test --tests dev.jbang.cli.TestInit— passes (31 tests, 1 skipped)./gradlew spotlessApply— passes./gradlew buildreaches tests; the four failures inTestScriptDownloadVersionandTestPluginsreproduce unchanged on currentmainin this environment.