Skip to content

[cmake] Require CMake 3.15 or newer #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gruenich
Copy link
Contributor

@gruenich gruenich commented Apr 29, 2025

  • The currently used version of Google-test 1.13 still triggers a CMake deprecation warning with CMake 3.30 or newer. We need to decide on which version of Google-test we want to update. I see no reason to not choose the most recent version 1.16 which requires C++14 (like Google-test 1.13) and CMake 3.13. (I went for Google-test 1.16)
  • Adjust CI to test for both CMake 3.15 and 4.0, the new min and max required version.

@henryiii
Copy link

For context, googletest does not specify a range, which is why the minimum matters there.

@gruenich gruenich force-pushed the feature/cmake-require-3.15 branch from bcaca6d to 35ad556 Compare May 1, 2025 17:21
@gruenich
Copy link
Contributor Author

gruenich commented May 1, 2025

@henryiii How did you image testing with distinct versions of CMake? Downloading and building CMake from source seems excessive.

@henryiii
Copy link

henryiii commented May 1, 2025

I do it in pybind11 and CLI11 (local support action). Basically jwlawson/actions-setup-cmake downloads binaries pretty quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants