emitter: emit quotes for non-plain scalars #1363
Conversation
Use the "!" tag to detect scalars that are not plain scalars and pass EMITTER_MANIP::DoubleQuoted to Emitter::Write() to ensure they are quoted. This preserves quotes on quoted items that do not strictly need quotes. The alternative of detecting and quoting only the values that need quotes seemed error-prone and brittle. Fixes jbeder#1362.
| out << n; | ||
| ExpectEmit("test"); | ||
| ExpectEmit(quoted); |
There was a problem hiding this comment.
This one is a little weird; I'd much prefer that it would display
test
rather than
"test"
since the quotes are redundant.
There was a problem hiding this comment.
The behavior is different, but seems reasonable (to me) since the input value was already quoted; it's not adding quotes. To maintain correct behavior while only quoting when strictly necessary requires a reliable way to detect that it's safe to omit quotes. #1276 mentions using "a laundry list of regexes, such as those for all the number formats, infinities, true/false etc." to check. Looking at the yaml spec, that seems error prone.
There was a problem hiding this comment.
Looking further in the yaml spec, it has a list of regular expressions in the Core Schema chapter. The regexes would be different for the fail-safe or json schemas, but AFAICT yaml-cpp does not support those.
Use the "!" tag to detect scalars that are not plain scalars and pass EMITTER_MANIP::DoubleQuoted to Emitter::Write() to ensure they are quoted.
This preserves quotes on quoted items that do not strictly need quotes. The alternative of detecting and quoting only the values that need quotes seemed error-prone and brittle.
Fixes #1362.