JBTM-3803 re-enable narayana-spring-boot quickstart #489
+170
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosgopen
commented
Oct 9, 2025
| * @author <a href="mailto:[email protected]">Zheng Feng</a> | ||
| */ | ||
| @Configuration | ||
| public class DbcpXADataSourceWrapper implements XADataSourceWrapper { |
There was a problem hiding this comment.
Deleted as already injected by NarayanaAutoConfiguration by dev.snowdrop
|
Started testing this pull request: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana-quickstart/437/ |
marcosgopen
commented
Oct 9, 2025
| private TransactionManager tm; | ||
|
|
||
| @Override | ||
| public DataSource wrapDataSource(XADataSource xaDataSource) throws Exception { |
There was a problem hiding this comment.
Using GenericXADataSourceWrapper by dev.snowdrop instead (see https://github.com/snowdrop/narayana-spring-boot/blob/fe90db50f0b1f706565cc768fbf63eda5df0aa96/narayana-spring-boot-core/src/main/java/dev/snowdrop/boot/narayana/core/jdbc/GenericXADataSourceWrapper.java#L100)
marcosgopen
force-pushed
the
JBTM-3803-wip
branch
from
de30bae to
00f4897
Compare
|
Started testing this pull request: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana-quickstart/438/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/JBTM-3803
Using dev.snowdrop dependency for narayana-spring-boot
to re-enable: