-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sqlx to 0.7.1 #33
Conversation
@@ -24,13 +24,14 @@ async_std = ["async-std"] | |||
mysql = ["sqlx/mysql", "sqlx/json"] | |||
|
|||
[dependencies] | |||
async-session = "3.0.0" | |||
sqlx = { version = "0.6.2", features = ["chrono"] } | |||
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fairly dangerous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, on the other hand, there's been no release in over 2 years and some of the deps updates are required for sqlx 0.7.1
async-session = "3.0.0" | ||
sqlx = { version = "0.6.2", features = ["chrono"] } | ||
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"} | ||
sqlx = { version = "0.7.1", features = [ "time" ] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the logic for switching to time
here? That seems unrelated to upgrading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to async-session
moving away from chrono
and to time
http-rs/async-session#35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope this makes sense. Ideally I'd move async-session
to a release. Filed http-rs/async-session#63 to nudge things along. Other than that I can just pin it to a commit which is slightly less risky.
@@ -24,13 +24,14 @@ async_std = ["async-std"] | |||
mysql = ["sqlx/mysql", "sqlx/json"] | |||
|
|||
[dependencies] | |||
async-session = "3.0.0" | |||
sqlx = { version = "0.6.2", features = ["chrono"] } | |||
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, on the other hand, there's been no release in over 2 years and some of the deps updates are required for sqlx 0.7.1
async-session = "3.0.0" | ||
sqlx = { version = "0.6.2", features = ["chrono"] } | ||
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"} | ||
sqlx = { version = "0.7.1", features = [ "time" ] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to async-session
moving away from chrono
and to time
http-rs/async-session#35
As per #32