Upgrading lodash to the latest version - #119
Open
jayakrishnagopal wants to merge 4 commits into
Open
Conversation
Fixing set vulnerability for lodash latest
Fixing older versions and implemeting set function
realdah
approved these changes
Feb 15, 2021
|
This is much required to be able to use mock-knex with latest lodash, please can owner review and approve this PR? |
|
Really appreciate this package! I ran into this same problem. I would love to see this get into the latest version so we can move up lodash. |
|
Also hit this one. Mock-knex is great! Even better with this shiny new set function 😉 |
|
Hey, @jbrumwell any thoughts on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of _.set in lodash ignores prototype to fix the prototype pollution issue mention by Snyk here - https://snyk.io/test/npm/lodash/4.17.15
I have implemented a simple set function to overcome this issue and help dependent projects move forward to the latest version of lodash.