Skip to content

fix for issue #72 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for issue #72 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dca5ecc
Issue#72 fix for outer field name
Apr 13, 2021
95750ee
Merge pull request #1 from eddurov/bugfix/issue-72
eddurov Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@
hs_err_pid*
.okhttpcache
.idea
*.iml
target
10 changes: 3 additions & 7 deletions ...main/java/com/github/jcustenborder/kafka/connect/transform/common/ExtractNestedField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@
import com.google.common.base.Strings;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.connect.connector.ConnectRecord;
import org.apache.kafka.connect.data.Field;
import org.apache.kafka.connect.data.Schema;
import org.apache.kafka.connect.data.SchemaAndValue;
import org.apache.kafka.connect.data.SchemaBuilder;
import org.apache.kafka.connect.data.Struct;
import org.apache.kafka.connect.data.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -71,7 +67,7 @@ protected SchemaAndValue processStruct(R record, Schema inputSchema, Struct inpu
for (Field inputField : inputSchema.fields()) {
builder.field(inputField.name(), inputField.schema());
}
builder.field(this.config.innerFieldName, innerField.schema());
builder.field(this.config.outputFieldName, innerField.schema());
return builder.build();
});
final Struct outputStruct = new Struct(outputSchema);
Expand All @@ -80,7 +76,7 @@ protected SchemaAndValue processStruct(R record, Schema inputSchema, Struct inpu
outputStruct.put(inputField.name(), value);
}
final Object innerFieldValue = innerStruct.get(this.config.innerFieldName);
outputStruct.put(this.config.innerFieldName, innerFieldValue);
outputStruct.put(this.config.outputFieldName, innerFieldValue);

return new SchemaAndValue(outputSchema, outputStruct);

Expand Down
6 changes: 3 additions & 3 deletions .../java/com/github/jcustenborder/kafka/connect/transform/common/ExtractNestedFieldTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void test() {
ImmutableMap.of(
ExtractNestedFieldConfig.INNER_FIELD_NAME_CONF, "state",
ExtractNestedFieldConfig.OUTER_FIELD_NAME_CONF, "address",
ExtractNestedFieldConfig.OUTPUT_FIELD_NAME_CONF, "state"
ExtractNestedFieldConfig.OUTPUT_FIELD_NAME_CONF, "newstate"
)
);

Expand All @@ -57,7 +57,7 @@ public void test() {
.field("first_name", Schema.STRING_SCHEMA)
.field("last_name", Schema.STRING_SCHEMA)
.field("address", innerSchema)
.field("state", Schema.STRING_SCHEMA)
.field("newstate", Schema.STRING_SCHEMA)
.build();
final Struct innerStruct = new Struct(innerSchema)
.put("city", "Austin")
Expand All @@ -70,7 +70,7 @@ public void test() {
.put("first_name", "test")
.put("last_name", "developer")
.put("address", innerStruct)
.put("state", "tx");
.put("newstate", "tx");

final SinkRecord inputRecord = new SinkRecord(
"topic",
Expand Down