Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add multilingual support for issue #9 #15

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Conversation

jdillard
Copy link
Owner

No description provided.

@humitos
Copy link

humitos commented Jan 16, 2019

Hi @jdillard! I'm starting to work on an implementation of readthedocs/readthedocs.org#557 and I'm making some decisions. I wanted to know if you are still working on this project and/or PR.

I suppose we are not going to install it by default on each build on Read the Docs, thought; but maybe suggest to our users.

So, no urgent, no needed, no nothing. Just asking about its status. Thanks a lot!

@jdillard
Copy link
Owner Author

Hey @humitos, that's great news! I can test and merge the two open PRs after work today.

I should be available if you plan on implementing it soonish and something comes up.

@humitos
Copy link

humitos commented Jan 16, 2019

I started with the general implementation for all the projects at readthedocs/readthedocs.org#5122 --I'd appreciate your feedback.

I have to decide how to do the other case: users generating their own sitemaps and RTD serving them under a global one with sitemapindex tags. Also, if you have more feedback about this case, please feel free to comment the PR or the issue itself.

@jdillard jdillard merged commit aa16a7b into master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants