Skip to content

Revert "Adds a CI job for testing code changes against known samples on the m…"#39

Merged
jeFF0Falltrades merged 1 commit intomasterfrom
revert-38-17-add-a-testing-pipeline-for-contributors
Jan 12, 2026
Merged

Revert "Adds a CI job for testing code changes against known samples on the m…"#39
jeFF0Falltrades merged 1 commit intomasterfrom
revert-38-17-add-a-testing-pipeline-for-contributors

Conversation

@jeFF0Falltrades
Copy link
Owner

Reverts #38

Whoops forgot to bump version so I'm going to do that (and note that we prob need to find a way to do this more automagically)

@jeFF0Falltrades jeFF0Falltrades merged commit d6da869 into master Jan 12, 2026
1 check failed
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jeFF0Falltrades, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily serves to undo a recent change that integrated a CI job for validating code against a set of known malware samples. The reversion involves removing the test infrastructure, sample data, and related configuration entries. Additionally, the project's version number has been decremented to reflect the state before the original change, with the author noting the need for a more automated version management process in the future.

Highlights

  • Revert of CI Job: This pull request fully reverts a previous change that introduced a CI job for testing code against known malware samples.
  • Version Downgrade: The project's version number has been explicitly rolled back from '4.2.2' to '4.2.1' in _version.py.
  • Cleanup of Test Artifacts: All associated test files, including the test_known_samples.py script and numerous tests/expected/*.json sample output files, have been removed.
  • Configuration Adjustments: The .gitignore file was updated to no longer ignore bin/ and tests/samples/, and pytest was removed from development dependencies in pyproject.toml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change that added a CI job for testing. The changes correctly roll back the version number, remove the test files and dependencies, and update the .gitignore. Overall, this is a clean revert. I've included one suggestion regarding the .gitignore file to maintain best practices for repository cleanliness and security.

@@ -3,5 +3,3 @@
__pycache__/
build/
*.egg-info/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change is part of reverting the previous pull request, it's good practice to keep directories like bin/ and tests/samples/ in .gitignore. This prevents accidental commits of build artifacts from bin/ and potentially sensitive malware samples from tests/samples/.

*.egg-info/
bin/
tests/samples/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant