Revert "Adds a CI job for testing code changes against known samples on the m…"#39
Conversation
Summary of ChangesHello @jeFF0Falltrades, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily serves to undo a recent change that integrated a CI job for validating code against a set of known malware samples. The reversion involves removing the test infrastructure, sample data, and related configuration entries. Additionally, the project's version number has been decremented to reflect the state before the original change, with the author noting the need for a more automated version management process in the future. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that added a CI job for testing. The changes correctly roll back the version number, remove the test files and dependencies, and update the .gitignore. Overall, this is a clean revert. I've included one suggestion regarding the .gitignore file to maintain best practices for repository cleanliness and security.
| @@ -3,5 +3,3 @@ | |||
| __pycache__/ | |||
| build/ | |||
| *.egg-info/ | |||
There was a problem hiding this comment.
While this change is part of reverting the previous pull request, it's good practice to keep directories like bin/ and tests/samples/ in .gitignore. This prevents accidental commits of build artifacts from bin/ and potentially sensitive malware samples from tests/samples/.
*.egg-info/
bin/
tests/samples/
Reverts #38
Whoops forgot to bump version so I'm going to do that (and note that we prob need to find a way to do this more automagically)