Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RTL languages punctuation mark issue #4422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orenskl
Copy link

@orenskl orenskl commented Jan 26, 2025

Changes
Add the unicode LTRM character for subtitles

Issues
Fixed #4296

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm sure this fixes the LTR issues, I'm not sure if this is a proper fix for the underlying issue. Modifying each line to force unicode directional marks into them seems like a hack we should not need to do, and it may even introduce side-effects.

@orenskl
Copy link
Author

orenskl commented Feb 20, 2025

I agree this is a hack/patch for this issue, while I did tested this with both LTR and RTL subtitles and it seems ok.
Subtitle direction should be handled correctly in the SubtitleView but I think there is a bug or an issue in the media3 library so I guess we will have to wait for it to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hebrew subtitles don't show up correctly on the latest version (0.18.2) on TV.
2 participants