Add Rewind & FastForward buttons to AudioNowPlayingFragment #4503
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -161,13 +161,27 @@ | |||
| android:layout_height="28sp" | |||
| android:src="@drawable/ic_previous" /> | |||
|
|
|||
| <ImageButton | |||
Check warning
Code scanning / Android Lint
Image without contentDescription Warning
| <ImageButton | ||
| android:id="@+id/playPauseBtn" | ||
| style="@style/Button.Icon" | ||
| android:layout_width="28sp" | ||
| android:layout_height="28sp" | ||
| android:src="@drawable/ic_pause" /> | ||
|
|
||
| <ImageButton |
Check warning
Code scanning / Android Lint
Image without contentDescription Warning
nielsvanvelzen
requested changes
Mar 10, 2025
Comment on lines
+277
to
+282
|
|
||
| val prefs = get<UserSettingPreferences>(UserSettingPreferences::class.java) | ||
| val amount = prefs.get<Int>(skipBackLength); | ||
| playbackManager.state.seek( | ||
| playbackManager.state.positionInfo.active - amount.toDuration(DurationUnit.MILLISECONDS), | ||
| ) |
There was a problem hiding this comment.
Should use the PlayerState rewind function
Comment on lines
+295
to
+299
| val prefs = get<UserSettingPreferences>(UserSettingPreferences::class.java) | ||
| val amount = prefs.get<Int>(skipForwardLength); | ||
| playbackManager.state.seek( | ||
| playbackManager.state.positionInfo.active + amount.toDuration(DurationUnit.MILLISECONDS), | ||
| ) |
There was a problem hiding this comment.
Should use the PlayerState fastForward function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added rewind and fast-forward buttons to to AudioNowPlayingFragment. These allow the user to seek audio content forward and backward by a predefined duration using the UI.
Issues