Display lyrics as captions #4504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share screenshots of what this actually changes? From the description I don't really understand what this does. |
|
Hi Niels,
Thank you for considering my pull request. The update is attempting to
improve the way lyrics are shown in the Android TV app. Please see the
attached screenshots, which shows the following:
1. Under the existing app behaviour, lyrics are always shown if
available, scrolling over the album artwork.
2. Under the update, lyrics are not automatically shown. A new lyrics
button has been added.
3. If you click on the lyrics button, scrolling lyrics are shown, per
the existing behaviour, and the lyrics button changes to "CC".
4. If you click on the lyrics button again, lyrics are shown as closed
captions, and the lyrics button changes to "CC (selected)".
5. If you click on the lyrics button again, the app cycles back to
showing no lyrics.
Regards
Albert
…On Tue, 11 Mar 2025 at 00:38, Niels van Velzen ***@***.***> wrote:
Can you share screenshots of what this actually changes? From the
description I don't really understand what this does.
—
Reply to this email directly, view it on GitHub
<#4504 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB25VI5FLHY7RY2JZHI6WW32TWIUJAVCNFSM6AAAAABYN5R2VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGYZDOMBVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: nielsvanvelzen]*nielsvanvelzen* left a comment
(jellyfin/jellyfin-androidtv#4504)
<#4504 (comment)>
Can you share screenshots of what this actually changes? From the
description I don't really understand what this does.
—
Reply to this email directly, view it on GitHub
<#4504 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB25VI5FLHY7RY2JZHI6WW32TWIUJAVCNFSM6AAAAABYN5R2VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGYZDOMBVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ok I'm starting to understand what this does, although I'd still appreciate screenshots of it as to me this doesn't feel like a useful change. We always display lyrics when available, and why would you even want to show them as closed captions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Lyrics on audio media are not displayed by default. Added a button to the audio player which cycles through showing no lyrics, showing scrolling lyrics (per existing functionality) or showing lyrics as closed captions. This implements: https://features.jellyfin.org/posts/3124/lyrics-as-closed-captions-on-androidvtv