Fix race condition in DefaultSocketApi causing disconnection loop when changing credentials #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the socket connection is disconnected we automatically reconnect when there's still active subscriptions.
The reconnect function will always disconnect any existing connection before opening a new one.
Now guess what can go wrong: whenever you reconnect, it will trigger the automatic reconnect. This will cause a reconnection loop. This issue could be triggered in the ATV app by changing users, where it updates the credentials and a reconnect is attempted.
The fix was easy, never initiate the automatic reconnect when an reconnect is already happening.
Fixes jellyfin/jellyfin-androidtv#4225