Skip to content

Support AWS endpoint configuration#11

Draft
chriskilding wants to merge 2 commits into
jenkinsci:masterfrom
chriskilding:add-endpoint-configuration
Draft

Support AWS endpoint configuration#11
chriskilding wants to merge 2 commits into
jenkinsci:masterfrom
chriskilding:add-endpoint-configuration

Conversation

@chriskilding
Copy link
Copy Markdown

@chriskilding chriskilding commented Feb 26, 2020

Allows AWS endpoint configuration (service endpoint, signing region) to be specified globally.

To do

  • Make EndpointConfiguration an f:optionalProperty (tick the box in the Jenkins UI if you want to override), and add the necessary tests.
  • EndpointConfiguration tests
  • Validate the config in doTestEndpointConfiguration()
  • Support 'Auto' for signingRegion in doTestEndpointConfiguration()
  • Use a service-independent API call to test endpoint connectivity (i.e. not ListSecrets)
  • Test locally with a real dependent plugin (probably S3 plugin)

@chriskilding
Copy link
Copy Markdown
Author

aws/aws-sdk-java#2251 says that the AWS API does not support generic authentication tests. We can only test aspects of that (does the URL look well-formed, do the config values look sane etc.)

@chriskilding
Copy link
Copy Markdown
Author

Yes, that was the idea. If client settings can be drawn from this plugin, then we wouldn't need per-plugin configuration for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants