Support AWS endpoint configuration#11
Draft
chriskilding wants to merge 2 commits into
Draft
Conversation
Author
|
aws/aws-sdk-java#2251 says that the AWS API does not support generic authentication tests. We can only test aspects of that (does the URL look well-formed, do the config values look sane etc.) |
Author
|
Yes, that was the idea. If client settings can be drawn from this plugin, then we wouldn't need per-plugin configuration for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows AWS endpoint configuration (service endpoint, signing region) to be specified globally.
To do
f:optionalProperty(tick the box in the Jenkins UI if you want to override), and add the necessary tests.doTestEndpointConfiguration()signingRegionindoTestEndpointConfiguration()ListSecrets)