Skip to content

Comments

getModuleRoot returnes now the full path included the part specified as load rules#28

Open
kkuehne wants to merge 9 commits intojenkinsci:masterfrom
kkuehne:master
Open

getModuleRoot returnes now the full path included the part specified as load rules#28
kkuehne wants to merge 9 commits intojenkinsci:masterfrom
kkuehne:master

Conversation

@kkuehne
Copy link

@kkuehne kkuehne commented Apr 2, 2014

This change is needed when ClearCase plugin for example is used together with the MavenPlugin. getModuleRoot never returned the full file path to the actual root module when load rules have been specified. So I would be more then happy to get the changes in to the master to fix that issue. Feedback is highly appriciated. Thanks, Karsten

@cloudbees-pull-request-builder

plugins » clearcase-plugin #66 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@cloudbees-pull-request-builder

plugins » clearcase-plugin #67 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

plugins » clearcase-plugin #68 SUCCESS
This pull request looks good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a build-scoped information, it shouldn't be persisted in the Scm object.

@Vlatombe
Copy link
Member

Vlatombe commented Apr 3, 2014

The referenced issue [JENKINS-18364] is not correct I believe, it should rather be JENKINS-22465

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major breaking change. All existing jobs that define the relative path in the view to reach the pom.xml for instance will have to be updated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iam suggesting having a checkbox in the job configuration which explicitly needs to be checked to have the load rule in the path of the module root . This way all the current job configuration will not be affected unless people want to have it.

@moshavnik
Copy link

any chance this will ever be pushed to master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants