getModuleRoot returnes now the full path included the part specified as load rules#28
getModuleRoot returnes now the full path included the part specified as load rules#28kkuehne wants to merge 9 commits intojenkinsci:masterfrom
Conversation
|
plugins » clearcase-plugin #66 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » clearcase-plugin #67 SUCCESS |
|
plugins » clearcase-plugin #68 SUCCESS |
There was a problem hiding this comment.
this is a build-scoped information, it shouldn't be persisted in the Scm object.
|
The referenced issue [JENKINS-18364] is not correct I believe, it should rather be JENKINS-22465 |
There was a problem hiding this comment.
This is a major breaking change. All existing jobs that define the relative path in the view to reach the pom.xml for instance will have to be updated.
There was a problem hiding this comment.
Iam suggesting having a checkbox in the job configuration which explicitly needs to be checked to have the load rule in the path of the module root . This way all the current job configuration will not be affected unless people want to have it.
|
any chance this will ever be pushed to master? |
This change is needed when ClearCase plugin for example is used together with the MavenPlugin. getModuleRoot never returned the full file path to the actual root module when load rules have been specified. So I would be more then happy to get the changes in to the master to fix that issue. Feedback is highly appriciated. Thanks, Karsten