Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitespace around origin list in config page #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow whitespace around origin list in config page #7

wants to merge 1 commit into from

Conversation

agentgonzo
Copy link

At the moment, if you try to configure the allowed origins section of the plugin with http://foo, http://bar, then it will add " http://bar" (note the leading space) to the list of allowed origins. When a request comes in from "http://bar", it will not match (due to the whitespace) so the plugin won't add the CORS header.

@agentgonzo
Copy link
Author

@uaarkoti @escoem - can you take a look at this please and merge if good?

@escoem
Copy link

escoem commented Sep 20, 2019

hey @agentgonzo I'm not maintainer of cors filter plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants