[JENKINS-59777] Allow nested docker.withRegistry() blocks #2#177
Open
PhilippHomann wants to merge 1 commit intojenkinsci:masterfrom
Open
[JENKINS-59777] Allow nested docker.withRegistry() blocks #2#177PhilippHomann wants to merge 1 commit intojenkinsci:masterfrom
PhilippHomann wants to merge 1 commit intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another approach to allow nested
docker.withRegistry()steps.When currently nesting
withRegistryit results in without losing credentials of the previous one.This PR only drops the blacklisted properties if the config.json is the one located in the users home directory.
If not the blacklisted properties are kept and the new registry is added.