Skip to content

inclusive language tags: jenkins_slave_type renamed to jenkins_node_type #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitrocode wants to merge 2 commits into
base: master
Choose a base branch
from
Open

inclusive language tags: jenkins_slave_type renamed to jenkins_node_type #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f522b26
jenkins_slave_type to jenkins_node_type
nitrocode Sep 16, 2020
c8c85b2
jenkins_slave_type to jenkins_node_type
nitrocode Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/hudson/plugins/ec2/EC2Tag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class EC2Tag extends AbstractDescribableImpl<EC2Tag> {
/**
* Tag name for the specific jenkins slave type tag, used to identify the EC2 instances provisioned by this plugin.
*/
public static final String TAG_NAME_JENKINS_SLAVE_TYPE = "jenkins_slave_type";
public static final String TAG_NAME_JENKINS_SLAVE_TYPE = "jenkins_node_type";
public static final String TAG_NAME_JENKINS_SERVER_URL = "jenkins_server_url";

@DataBoundConstructor
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/hudson/plugins/ec2/AmazonEC2CloudUnitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public void testSpotInstanceCount() throws Exception {

List<Instance> instances = new ArrayList<Instance>();
for(int i=0; i<=numberOfSpotInstanceRequests; i++) {
instances.add(new Instance().withInstanceId("id"+i).withTags(new Tag().withKey("jenkins_slave_type").withValue("spot")));
instances.add(new Instance().withInstanceId("id"+i).withTags(new Tag().withKey("jenkins_node_type").withValue("spot")));
}

AmazonEC2FactoryMockImpl.instances = instances;
Expand Down