Skip to content

Bump powershell from 1.3 to 1.4#226

Closed
dependabot[bot] wants to merge 3 commits intodevelopfrom
dependabot/maven/org.jenkins-ci.plugins-powershell-1.4
Closed

Bump powershell from 1.3 to 1.4#226
dependabot[bot] wants to merge 3 commits intodevelopfrom
dependabot/maven/org.jenkins-ci.plugins-powershell-1.4

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 17, 2021

Bumps powershell from 1.3 to 1.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @olamy.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 17, 2021
@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci.plugins-powershell-1.4 branch from 9c20ce5 to 278bd59 Compare February 17, 2021 20:15
@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci.plugins-powershell-1.4 branch from 278bd59 to 22e6809 Compare February 18, 2021 21:51
@alecharp
Copy link
Member

The build issue here is because jenkinsci/powershell-plugin changed the signature of the Powershell constructor, adding two mandatory parameter, without providing a escape. See the commits jenkinsci/powershell-plugin@8448ba0 and jenkinsci/powershell-plugin@f7b965b.

@alecharp
Copy link
Member

this is a problem in

return new PowerShell(String.format(command.getWindows(), argument));
.

Changing the line to

return new PowerShell(String.format(command.getWindows(), argument), true, false);

fixed the build locally. As I don't have write permission here, I can only a PR to offer the fix.

@donmccasland
Copy link
Collaborator

donmccasland commented Feb 19, 2021 via email

@alecharp
Copy link
Member

alecharp commented Mar 1, 2021

This also has to be merged. I incorrectly thought #237 was targeting develop branch. cc @donmccasland

Fixes powershell plugin upgrade due to constructor signature change
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 5, 2021

A newer version of org.jenkins-ci.plugins:powershell exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@olamy
Copy link
Member

olamy commented Mar 21, 2023

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 21, 2023

Superseded by #382.

@dependabot dependabot bot closed this Mar 21, 2023
@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci.plugins-powershell-1.4 branch March 21, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants